New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ValueTask as a return type of the hub method. #583

Merged

mayuki merged 1 commit into 5.0 from feature/HubMethodValueTask

Dec 14, 2022

Member

mayuki commented Dec 14, 2022

This PR allows ValueTask and ValueTask<T> as a return type of the hub method. Previously, only Task wereTask<T> was allowed.

Example

public interface IMyHub : IStreamingHub<IMyHub, IMyHubReceiver>
{
    ValueTask FooAsync();
    ValueTask<int> BarAsync();
}


          Allow ValueTask as a return type of the hub method.

86968c9

mayuki mentioned this pull request

MagicOnion 5.0 #497

Merged

28 tasks

mayuki merged commit f3825a0 into 5.0

mayuki deleted the feature/HubMethodValueTask branch

December 14, 2022 08:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet